• From: Gothenburg, Sweden
  • Registered: 08-09-2009
  • Posts: 1,419

Topic: Small fix in hellmat and hydram

I'm not sure how you'd like patches organized, so i guess i'll do what i would have preferred.
I'll start off with some minor bugs which have been annoying my for some time.

Bug descriptions:
* typedef enum's are not required in C++ (gives an annoying warning.

* Hellmat.* messed up the namespaces in the ifdef's.

Patch applied.

2 Reply by bp

  • bp
  • Administrator
  • Offline
  • From: Prague, Czech Rep.
  • Registered: 02-03-2007
  • Posts: 1,047

Re: Small fix in hellmat and hydram

Dear Mikael,

I have a simple policy: send me your patches, I will review them and if they will be ok, I will apply them. If not, I will ask you to make required changes. Later, I can  create a svn account for you, but I want to see some real oofem code from you, not only bug fixes, so that I can make sure that you understand the structure and coding standards. This will allow you to submit patches directly into the repository, so you can always fix bugs and submit your work. On the other hand, a big changes should be always discussed in advance.

Patches should be always created against current repository version.
I am little confused from your post, you refer to some patch you created, but nothing is attached.

Borek.

bp's Website

  • From: Gothenburg, Sweden
  • Registered: 08-09-2009
  • Posts: 1,419

Re: Small fix in hellmat and hydram

Sorry for the late reply.

I could have sworn I attached the patch!

However, it's so minor, and looking more closely, hydram and hellmat seems to be rather messy to begin with (no doxygen, etc.) so it might not be worth looking at. This was just something that i found when i was testing out the CMake scripts.