1

Topic: Checks before commiting

As we have now a long period, where tests and compilation of induvidual targets are failing quite often, I just want to recall important
Checks before committing

  • Test your implementation before committing. Configure at least serial and parallel version, run the tests (just do "make tests")and check the results. Compile your sources with ”-Wall”, which will enable all the compiler warnings. Check compiler messages and clean up the code.

  • For new work, check if documentation is updated as well (includes not only doc++ comments, but also oofem documentation, that can be affected). Making it later usually means never

  • Reformat your code using uncrustify tool

Also make sure, that your email client will not detect the OOFEM-nightly reports as spam. These reports are sent, when regular nightly tests fail. The sender of the report is bp@mech.fsv.cvut.cz and the subject is "OOFEM-nightly build report".
You can also check the nightly results on the following web page: http://www.oofem.org/oofem-nightly.html