oofem-wiki

You've loaded an old revision of the document! If you save it, you will create a new version with this data.

This page contains an instructions and guidelines for lieutenants. Lieutenants are experienced developers and maintainers, usually in charge of a specific subsystem of the project and they merge in changes from individual developers and push to the reference (blessed) repository that everyone then clones from again.

:!: Remember: As Lieutenant you are responsible for the project, so you have to make sure, that the contributed work meets all requirements:
  * [[coding-conventions|oofem coding conventions]] have been followed,
  * sufficient documentation and internal tests provided

====== Reviewing changes in pull requests ======
Reviews allow leutnants and other collaborators to comment on the changes proposed in pull requests, approve the changes, or request further changes before the pull request is merged. OOFEM settings require that all pull requests to the master branch are approved before being merged.

* [[https://help.github.com/articles/reviewing-changes-in-pull-requests/| Reviewing changes in pull requests]]
   * [[https://help.github.com/articles/incorporating-changes-from-a-pull-request/|Incorporating changes from a pull request]]

Edit summary

Note: By editing this page you agree to license your content under the following license: CC Attribution-Share Alike 4.0 International