This shows you the differences between two versions of the page.
Both sides previous revision Previous revision | |||
git-for-lieutenants [2017/11/01 09:17] bp |
git-for-lieutenants [2017/11/01 09:23] (current) bp |
||
---|---|---|---|
Line 2: | Line 2: | ||
:!: Remember: As Lieutenant you are responsible for the project, so you have to make sure, that the contributed work meets all requirements: | :!: Remember: As Lieutenant you are responsible for the project, so you have to make sure, that the contributed work meets all requirements: | ||
- | * [[coding-conventions|oofem coding conventions]] have been followed, | + | * [[coding-conventions|oofem coding conventions]] have been followed |
+ | * [[coding-conventions#Checks before committing|Checks before accepting pull request]] | ||
* sufficient documentation and internal tests provided | * sufficient documentation and internal tests provided | ||